Skip to content

[Fiber]Warn when shoulcComponentUpdate returns undefined#8243

Merged
gaearon merged 2 commits intofacebook:masterfrom
koba04:fiber-warn-scu-returns-undefined
Nov 9, 2016
Merged

[Fiber]Warn when shoulcComponentUpdate returns undefined#8243
gaearon merged 2 commits intofacebook:masterfrom
koba04:fiber-warn-scu-returns-undefined

Conversation

@koba04
Copy link
Copy Markdown
Contributor

@koba04 koba04 commented Nov 9, 2016

No description provided.

@gaearon
Copy link
Copy Markdown
Collaborator

gaearon commented Nov 9, 2016

Looks good, thank you!

@gaearon gaearon merged commit d0a8d8b into facebook:master Nov 9, 2016
@koba04 koba04 deleted the fiber-warn-scu-returns-undefined branch November 9, 2016 17:14
@koba04
Copy link
Copy Markdown
Contributor Author

koba04 commented Nov 9, 2016

Thanks!

acusti pushed a commit to brandcast/react that referenced this pull request Mar 15, 2017
* [Fiber]Warn when shoulcComponentUpdate returns undefined

* Remove unnecessary fallback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants